Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update docs for linux install #159

Merged
merged 1 commit into from
Feb 22, 2024
Merged

fix: update docs for linux install #159

merged 1 commit into from
Feb 22, 2024

Conversation

nvtkaszpir
Copy link
Contributor

What type of PR is this?

documentation

Which issue does this PR fix:

What does this PR do / Why do we need it:

I have added some missing steps in the installation.
Fixes minor formatting issues.

Will this break upgrades or downgrades?

No.

Does this PR introduce any user-facing change?:
Just documentation updates, added missing steps.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rchincha
Copy link
Contributor

@nvtkaszpir what is the goal of this PR? whitespacing?

@nvtkaszpir
Copy link
Contributor Author

@rchincha as stated in PR description

  1. add missing steps in bare metal installation such as:
  • better order of installing zot with sudo wget
  • moving line related to chmodding and chowning downloaded binary just after downloading binary
  • chowning /etc/zot dir instead of just the config file
  • systemd daemon-reload after adding new unit file
  • using zot verify after editing zot config
  1. Fix some white spaces or new lines
  • some of them made markdown preview not working in editors
  • trimming too long lines.

I see.Inneed to do some other things as well as I see checks are failing. I'll do it in the evening.

andaaron
andaaron approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@andaaron andaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvtkaszpir nvtkaszpir requested a review from andaaron February 21, 2024 18:21
mbshields
mbshields approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@mbshields mbshields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nvtkaszpir
Copy link
Contributor Author

Updated commit message to be compatible with commit message style

@nvtkaszpir nvtkaszpir changed the title Update docs for linux install docs: update docs for linux install Feb 21, 2024
@rchincha
Copy link
Contributor

rchincha commented Feb 21, 2024 •
edited
Loading

Checking commit messages against "^((build|chore|ci|docs|feat|fix|perf|refactor|revert|style|test)((.+))?(!)?(: (.\s)*))"...

  • failed: "Update docs for linux install

@nvtkaszpir
Pls start your commit msg with "fix: update docs for linux install"

@nvtkaszpir nvtkaszpir changed the title docs: update docs for linux install fix: update docs for linux install Feb 21, 2024
@nvtkaszpir
Copy link
Contributor Author

Checking commit messages against "^((build|chore|ci|docs|feat|fix|perf|refactor|revert|style|test)((.+))?(!)?(: (.\s)*))"...

  • failed: "Update docs for linux install

@nvtkaszpir Pls start your commit msg with "fix: update docs for linux install"

yeah, totally forgot that PR title goes as commit message, fixed

@rchincha
Copy link
Contributor

rchincha commented Feb 21, 2024 •
edited
Loading

Checking commit messages against "^((build|chore|ci|docs|feat|fix|perf|refactor|revert|style|test)((.+))?(!)?(: (.\s)*))"...

  • failed: "Update docs for linux install

@nvtkaszpir Pls start your commit msg with "fix: update docs for linux install"

yeah, totally forgot that PR title goes as commit message, fixed

Not the title, the actual commit msg.
38160df
First line of the msg should be
"fix: update docs for linux install" (for example)

Apologies for the nitpick.

@nvtkaszpir
fix: update docs for linux install
6157709 
Minor formatting fixes

Signed-off-by: Michał Sochoń <[email protected]>
@nvtkaszpir
Copy link
Contributor Author

Arg I just noticed that somehow my commit message was not amended before. Sorry.

rchincha
rchincha approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit 9d8c6e5 into project-zot:main Feb 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchincha rchincha rchincha approved these changes

@mbshields mbshields mbshields approved these changes

@andaaron andaaron Awaiting requested review from andaaron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nvtkaszpir @rchincha @mbshields @andaaron